Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add metrics for parquet page level skipping #4086

Closed
Tracked by #4085
alamb opened this issue Nov 2, 2022 · 0 comments · Fixed by #4105
Closed
Tracked by #4085

Add metrics for parquet page level skipping #4086

alamb opened this issue Nov 2, 2022 · 0 comments · Fixed by #4105

Comments

@alamb
Copy link
Contributor

alamb commented Nov 2, 2022

Usecase is that as we work on #4085 we need to have some way to:

  1. Verify page index filtering is actually working / enabled as expected
  2. Evaluate its efficiency (how long it takes, etc) to see if further optimizations are needed

What I would like is:

  1. Add metrics for "how many rows were pruned using page level skipping" and "how long did the page level skipping code take"

Related work is this PR that added similar metrics for filter pushdown (see #3989) -- we can probably follow a similar approach

cc @Ted-Jiang

@Dandandan Dandandan changed the title Add statistics for parquet page level skipping Add metrics for parquet page level skipping Nov 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant