Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make ExecutionProps a Trait #4629

Open
tustvold opened this issue Dec 14, 2022 · 0 comments
Open

Make ExecutionProps a Trait #4629

tustvold opened this issue Dec 14, 2022 · 0 comments
Assignees
@tustvold
Labels
enhancement New feature or request

Comments

@tustvold
Copy link
Contributor

Is your feature request related to a problem or challenge? Please describe what you are trying to do.

ExecutionProps provides the information needed to lower an Expr to an Arc<dyn PhysicalExpr>. Currently it lives on SessionState where the additional nesting adds to the confusing config situation (#4349)

Describe the solution you'd like

I would like to refactor ExecutionProps to be a trait and passed to create_physical_expr as &dyn ExecutionProps, this could then be implemented by SessionState (or DataFrame #4626)

This would help reduce the config struct proliferation, whilst keeping the existing separation between the crates.

Describe alternatives you've considered

Additional context
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tustvold tustvold

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tustvold