Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent behavior with PostgreSQL to decide Window Expressions ordering #4641

Closed
mingmwang opened this issue Dec 15, 2022 · 0 comments · Fixed by #4643
Closed

Inconsistent behavior with PostgreSQL to decide Window Expressions ordering #4641

mingmwang opened this issue Dec 15, 2022 · 0 comments · Fixed by #4643
Labels
enhancement New feature or request

Comments

@mingmwang
Copy link
Contributor

Is your feature request related to a problem or challenge? Please describe what you are trying to do.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
(This section helps Arrow developers understand the context and why for this feature, in addition to the what)

DataFusion's current implement only checks the length of the sort exprs, and does not consider the column indexes, sort options(Asc/Desc and Nulls First/Nulls Last). The current implement claims to align with PG's rule but actually are not exactly matching.

See PG's source code select_active_windows and common_prefix_cmp
https://github.com/postgres/postgres/blob/master/src/backend/optimizer/plan/planner.c

Describe the solution you'd like
A clear and concise description of what you want to happen.

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
Add any other context or screenshots about the feature request here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
1 participant