Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port other sql_integration test cases to sqllogictest #4870

Closed
Tracked by #4460
ygf11 opened this issue Jan 11, 2023 · 3 comments
Closed
Tracked by #4460

Port other sql_integration test cases to sqllogictest #4870

ygf11 opened this issue Jan 11, 2023 · 3 comments
Labels
enhancement New feature or request

Comments

@ygf11
Copy link
Contributor

ygf11 commented Jan 11, 2023

Is your feature request related to a problem or challenge? Please describe what you are trying to do.

As @jackwener suggested in #4826 (comment), we can port the other part of sql_integration to sqllogictest now.
The sql_integration tests are in datafusion/core/tests/sql:

aggregates.rs
avro.rs
cast.rs
create_drop.rs
decimal.rs
errors.rs
explain_analyze.rs
...

The difference:

  • sql_integration will ensure the correctness of logical and physical plan.
  • sqllogictest will ensure the result is correct.

For the test cases, if we want to ensure the correctness of the plan, the test should be reserved in sql_integration.

Describe the solution you'd like
A clear and concise description of what you want to happen.

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
Add any other context or screenshots about the feature request here.

@alamb
Copy link
Contributor

alamb commented Jan 11, 2023

Captured on #4460 where I have been collecting other related tickets

@aprimadi
Copy link
Contributor

Isn't this a duplicate of 4495

@alamb
Copy link
Contributor

alamb commented Apr 24, 2023

Yes, I agree -- thank you @aprimadi - closing in favor of #4495

@alamb alamb closed this as completed Apr 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants