Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use compute_op_dyn_scalar for datatime #5314

Closed
viirya opened this issue Feb 16, 2023 · 0 comments · Fixed by #5315
Closed

Use compute_op_dyn_scalar for datatime #5314

viirya opened this issue Feb 16, 2023 · 0 comments · Fixed by #5315
Labels
enhancement New feature or request

Comments

@viirya
Copy link
Member

viirya commented Feb 16, 2023

Is your feature request related to a problem or challenge? Please describe what you are trying to do.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
(This section helps Arrow developers understand the context and why for this feature, in addition to the what)

We found that DataFusion fails to perform comparison (e.g. LtEq) on DictionaryArray of datetime type (e.g. Date32). The issue at DataFusion side is that binary_array_op_dyn_scalar calls compute_op_scalar for datetime types instead of compute_op_dyn_scalar which calls dyn comparison kernels.

Describe the solution you'd like
A clear and concise description of what you want to happen.

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
Add any other context or screenshots about the feature request here.

@viirya viirya added the enhancement New feature or request label Feb 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant