LogicalPlan::replace_params_with_values
should not take &Vec<_>
#5573
Labels
bug
Something isn't working
Describe the bug
LogicalPlan::replace_params_with_values
takes&Vec<ScalarValue>
, forcing the caller to collect inputs inVec<ScalarValue>
(instead of an arbitrary continuous container) with no benefits.https://github.com/apache/arrow-datafusion/blob/aeb593f719508973fa4564a32bc2adc767c3713e/datafusion/expr/src/logical_plan/plan.rs#L630-L636
To Reproduce
N/A
Expected behavior
A common practice, enforced by the
ptr_arg
Clippy lint, is to pass such parameters by slice references (&[ScalarValue]
).Additional context
N/A
The text was updated successfully, but these errors were encountered: