Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LogicalPlan::replace_params_with_values should not take &Vec<_> #5573

Closed
kawadakk opened this issue Mar 13, 2023 · 1 comment · Fixed by #5640
Closed

LogicalPlan::replace_params_with_values should not take &Vec<_> #5573

kawadakk opened this issue Mar 13, 2023 · 1 comment · Fixed by #5640
Labels
bug Something isn't working

Comments

@kawadakk
Copy link
Contributor

Describe the bug
LogicalPlan::replace_params_with_values takes &Vec<ScalarValue>, forcing the caller to collect inputs in Vec<ScalarValue> (instead of an arbitrary continuous container) with no benefits.

https://github.com/apache/arrow-datafusion/blob/aeb593f719508973fa4564a32bc2adc767c3713e/datafusion/expr/src/logical_plan/plan.rs#L630-L636

To Reproduce
N/A

Expected behavior
A common practice, enforced by the ptr_arg Clippy lint, is to pass such parameters by slice references (&[ScalarValue]).

Additional context
N/A

@kawadakk kawadakk added the bug Something isn't working label Mar 13, 2023
@HaoYang670
Copy link
Contributor

Thank you, @kawadakk, for reporting this. I will try to fix it this weekend.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
2 participants