Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pruning on != predicate results in incorrect results #560

Closed
alamb opened this issue Jun 14, 2021 · 0 comments · Fixed by #561
Closed

Pruning on != predicate results in incorrect results #560

alamb opened this issue Jun 14, 2021 · 0 comments · Fixed by #561
Labels
bug Something isn't working

Comments

@alamb
Copy link
Contributor

alamb commented Jun 14, 2021

Describe the bug
The logic for pruning on != predicates introduced in #544 is incorrect

To Reproduce
Use the pruning logic with a != predicate where the range covers the expression

So like s != M where the min/max is A -> Z.

Expected behavior
Must check all values in block (as s!=M might be true for every one)

Actual behavior: Pruning logic says we must look at it.

Additional context
I found this issue when integrating / testing DataFusion into IOx here: https://github.com/influxdata/influxdb_iox/pull/1721#issuecomment-860858033

@alamb alamb added the bug Something isn't working label Jun 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant