Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move some rules and code into Analyzer #5681

Closed
jackwener opened this issue Mar 22, 2023 · 1 comment
Closed

Move some rules and code into Analyzer #5681

jackwener opened this issue Mar 22, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@jackwener
Copy link
Member

jackwener commented Mar 22, 2023 •
edited
Loading

Is your feature request related to a problem or challenge?

Describe the solution you'd like

Move some rules and code into Analyzer

  • InlineTableScan
  • TypeCoercion
  • ...

Describe alternatives you've considered

No response

Additional context

No response
@jackwener jackwener added the enhancement New feature or request label Mar 22, 2023
@jackwener jackwener mentioned this issue Mar 22, 2023
Closed
@mslapek
Copy link
Contributor

mslapek commented Mar 25, 2023

This is a very important feature. 🪜

Moving TypeCoercion into pre-optimizer phase would allow to avoid "Mismatch between schema and batches", like #5733 (and possibly #5695).

TypeCoercion being an optimizer is a broken concept - because optimizers cannot change the final schema of the logical plan.

What is more, Expr::Case has an assumption, that all inputs are already coerced.

@mslapek mslapek mentioned this issue Mar 26, 2023
Merged
@comphead comphead mentioned this issue Mar 26, 2023
Closed
6 tasks
@alamb alamb mentioned this issue Apr 3, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mslapek @jackwener