Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for StructArray to ScalarValue #602

Closed
jorgecarleitao opened this issue Jun 22, 2021 · 2 comments · Fixed by #1091
Closed

Add support for StructArray to ScalarValue #602

jorgecarleitao opened this issue Jun 22, 2021 · 2 comments · Fixed by #1091
Labels
enhancement New feature or request

Comments

@jorgecarleitao
Copy link
Member

Enabling DataFusion to support StructArray for some of its scalar operations.

Note that this may be difficult to support in Ballista due to how scalar values are currently represented in the proto, so I suggest we restrict this to DataFusion for now.

@jonmmease
Copy link
Contributor

I would like to work on this. I have a local branch where I've added the following as a new ScalarValue variant:

Struct(Option<Box<Vec<ScalarValue>>>, Box<Vec<Field>>)

mirroring the current List variant

List(Option<Box<Vec<ScalarValue>>>, Box<DataType>)

Does that make sense as a starting point?

@houqp
Copy link
Member

houqp commented Oct 9, 2021

sorry for the delay @jonmmease , i think so, please feel free to send a PR and we can discuss further there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants