Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Substrait: Support for more flexible join condition expressions #6544

Closed
nseekhao opened this issue Jun 5, 2023 · 2 comments
Closed

Substrait: Support for more flexible join condition expressions #6544

nseekhao opened this issue Jun 5, 2023 · 2 comments
Labels
enhancement New feature or request substrait

Comments

@nseekhao
Copy link
Contributor

nseekhao commented Jun 5, 2023

Is your feature request related to a problem or challenge?

If you run a roundtrip test on

SELECT d1.b, d2.c FROM data d1 JOIN data d2 ON CAST(d1.b AS int) = d2.e

you'll got the error Error: Internal("invalid join condition expression").

This is due to the lack of support of expressions not in the form AND(f0(...), ..., fk(...)), where fi() is EQ() in the consumer (ref).

Describe the solution you'd like

Support for more arbitrary join condition expressions.

Describe alternatives you've considered

This effort can be incremental. I just wanted to make sure this gets brought up and tracked.

Additional context

No response

@alamb
Copy link
Contributor

alamb commented Jun 11, 2023

I wonder if #6135 fixes this?

@waynexia
Copy link
Member

The new roundtrip tests cover SQL in this issue (except the CAST part). Closing this ticket

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request substrait
Projects
None yet
Development

No branches or pull requests

3 participants