Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TPC-H q8 fails with overflow (since version 28) #7216

Closed
andygrove opened this issue Aug 7, 2023 · 4 comments · Fixed by #7233
Closed

TPC-H q8 fails with overflow (since version 28) #7216

andygrove opened this issue Aug 7, 2023 · 4 comments · Fixed by #7233
Labels
bug Something isn't working

Comments

@andygrove
Copy link
Member

andygrove commented Aug 7, 2023 •
edited
Loading

Describe the bug

Arrow error: Compute error: Overflow happened on: 19293795273 * 100000000000000000000000000000000000000

To Reproduce

Here is a Google colab notebook that demonstrates the issue

https://colab.research.google.com/drive/13vCffhO1-IP3NtXT1FgO-j6MwoQZlPtm?usp=sharing

Expected behavior

No response

Additional context

This was originally discovered by Mimoune Djouallah:

https://twitter.com/mim_djo/status/1686955130812542976?s=20
@andygrove andygrove added the bug Something isn't working label Aug 7, 2023
@andygrove andygrove changed the title TPC-H q8 fails with overflow (seems to be a new regression in 28.0.0) TPC-H q8 fails with overflow\ Aug 7, 2023
@andygrove andygrove changed the title TPC-H q8 fails with overflow\ TPC-H q8 fails with overflow Aug 7, 2023
@andygrove andygrove changed the title TPC-H q8 fails with overflow TPC-H q8 fails with overflow (since version 28) Aug 7, 2023
@andygrove
Copy link
Member Author

I confirmed that this issue does not happen with version 27

@andygrove
Copy link
Member Author

Ok, I see that earlier versions returned the wrong result. It is better now that we fail, but will leave this issue open because we shouldn't fail either.

Related issue: #6794

@alamb
Copy link
Contributor

alamb commented Aug 8, 2023

I think this may be fixed now that #6832 has been merged

@viirya viirya mentioned this issue Aug 8, 2023
Merged
@viirya
Copy link
Member

viirya commented Aug 8, 2023

I've added additional cast to make TPCH q8 pass under benchmark. Let's see now if it can be passed after #6832.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove additional cast from TPCH q8 viirya/arrow-datafusion
3 participants
@viirya @alamb @andygrove