Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

datafusion-examples crate fails after upgrade to arrow 5.1.0 #817

Closed
alamb opened this issue Aug 2, 2021 · 0 comments · Fixed by #818
Closed

datafusion-examples crate fails after upgrade to arrow 5.1.0 #817

alamb opened this issue Aug 2, 2021 · 0 comments · Fixed by #818
Assignees
Labels
bug Something isn't working

Comments

@alamb
Copy link
Contributor

alamb commented Aug 2, 2021

Describe the bug
The tests in the datafusion-examples fail after upgrade to arrow 5.1.0 (they worked on 5.0.0).

I believe the issue is some incompatible version of tonic -- the 5.1.0 release updated tonic

To Reproduce

cargo update # <-- critical to get arrow 5.1.0 update
cargo test --all

Results in these failures:

   Compiling datafusion-examples v4.0.0-SNAPSHOT (/Users/alamb/Software/arrow-datafusion/datafusion-examples)
error[E0271]: type mismatch resolving `<Pin<Box<(dyn futures::Stream<Item = std::result::Result<HandshakeResponse, Status>> + Sync + std::marker::Send + 'static)>> as futures::Stream>::Item == std::result::Result<HandshakeResponse, tonic::status::Status>`
   --> datafusion-examples/examples/flight_server.rs:40:5
    |
40  | /     type HandshakeStream = Pin<
41  | |         Box<dyn Stream<Item = Result<HandshakeResponse, Status>> + Send + Sync + 'static>,
42  | |     >;
    | |______^ expected struct `tonic::status::Status`, found struct `Status`
    | 
   ::: /Users/alamb/.cargo/registry/src/github.com-1ecc6299db9ec823/arrow-flight-5.1.0/src/arrow.flight.protocol.rs:514:52
    |
514 |           type HandshakeStream: futures_core::Stream<Item = Result<super::HandshakeResponse, tonic::Status>>
    |                                                      ------------------------------------------------------- required by this bound in `arrow_flight::flight_service_server::FlightService::HandshakeStream`
    |
    = note: expected enum `std::result::Result<_, tonic::status::Status>`
               found enum `std::result::Result<_, Status>`
    = note: perhaps two different versions of crate `tonic` are being used?

Expected behavior
All tests pass

Additional context
Add any other context about the problem here.

@alamb alamb added the bug Something isn't working label Aug 2, 2021
@alamb alamb self-assigned this Aug 2, 2021
@alamb alamb closed this as completed in #818 Aug 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant