Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve statistics test coverage #8228

Open
8 tasks
alamb opened this issue Nov 15, 2023 · 0 comments
Open
8 tasks

Improve statistics test coverage #8228

alamb opened this issue Nov 15, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@alamb
Copy link
Contributor

alamb commented Nov 15, 2023

Is your feature request related to a problem or challenge?

It is clear that the current statistics code is lacking tests . For example I was about to delete code #8172 but thankfully @berkaysynnada pointed out the code was actually different, yet not tests failed.

I spent some time auditing the codebase for tests, and here is what I found:

places that I think could do with some additional coverage

These places have tests, but we should review them to ensure that the coverage is adequte

Here are the places that do have tests, but the coverage probably needs to be reviewed

places that appear to be lacking coverage at all

Here are impl ExecutionPlan that implement statistics but I didn't find any tests (though I could have missed them)

Describe the solution you'd like

Review and add coverage as necessary to locations above

Describe alternatives you've considered

No response

Additional context

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant