Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port tests in array_expression.rs to sqllogictest #8324

Closed
13 tasks
jayzhan211 opened this issue Nov 27, 2023 · 4 comments · Fixed by #8332
Closed
13 tasks

Port tests in array_expression.rs to sqllogictest #8324

jayzhan211 opened this issue Nov 27, 2023 · 4 comments · Fixed by #8332

Comments

@jayzhan211
Copy link
Contributor

jayzhan211 commented Nov 27, 2023 •
edited
Loading

The goal is that there is no rust test in this file anymore.

Part of #6195

Originally posted by @alamb in #8313 (comment)

File an issue to list the pending test to avoid duplicate work

  • make_array
  • array_element
  • array_pop_back
  • array_slice
  • array_append
  • array_prepend
  • array_concat
  • array_position
  • array_to_string
  • cardinality
  • array_length
  • array_dims
  • Port other function to common::utils or just remove it
@jayzhan211 jayzhan211 changed the title Cleanup unit_test in array_expression.rs Port tests in array_expression.rs to sqllogictest Nov 27, 2023
@Veeupup
Copy link
Contributor

Veeupup commented Nov 27, 2023 •
edited
Loading

hi @jayzhan211, I can help with make_array array_element array_pop_back

@jayzhan211
Copy link
Contributor Author

hi @jayzhan211, I can help with make_array array_element array_pop_back

Sure! Go ahead.

@Veeupup
Copy link
Contributor

Veeupup commented Nov 27, 2023

: )
I find that almost all test cases have been added to the sqllogictest, so I just remove some duplicate test codes then

@jayzhan211
Copy link
Contributor Author

jayzhan211 commented Nov 27, 2023 •
edited
Loading

: ) I find that almost all test cases have been added to the sqllogictest, so I just remove some duplicate test codes then

Close this issue with only delete, cool

@Veeupup Veeupup mentioned this issue Nov 27, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

move array function unit_tests to sqllogictest Veeupup/arrow-datafusion
2 participants
@jayzhan211 @Veeupup