Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bloom filter integration tests #8768

Closed
alamb opened this issue Jan 5, 2024 · 0 comments · Fixed by #8772
Closed

Add bloom filter integration tests #8768

alamb opened this issue Jan 5, 2024 · 0 comments · Fixed by #8772
Labels
enhancement New feature or request

Comments

@alamb
Copy link
Contributor

alamb commented Jan 5, 2024

Is your feature request related to a problem or challenge?

We (well, really I) introduced a regression applying BloomFilters in ParquetExec #8685

Part of why this regression was introduced is that there are no "end to end" integration tests of reading parquet files with bloom filters (e.g. actually write parquet data with bloom filters, and verify they are being used to prune row groups)

Describe the solution you'd like

  1. One PR with some integration tests to verify bloom filters are actually pruning (maybe following how it is done in https://github.com/apache/arrow-datafusion/blob/1179a76567892b259c88f08243ee01f05c4c3d5c/datafusion/core/tests/parquet/row_group_pruning.rs#L42)

Describe alternatives you've considered

No response

Additional context

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant