Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NestedLoopsJoin memory tracking may be insufficient #8952

Open
alamb opened this issue Jan 22, 2024 · 3 comments
Open

NestedLoopsJoin memory tracking may be insufficient #8952

alamb opened this issue Jan 22, 2024 · 3 comments
Labels
enhancement New feature or request

Comments

@alamb
Copy link
Contributor

alamb commented Jan 22, 2024

Is your feature request related to a problem or challenge?

Similarly to #7848, @metesynnada noted #8020 (comment) that it is possible for NestedLoopsJoin to generate a single (very) large RecordBatch. For certain pathalogical queries this may lead to DataFusion far exceeding its memory limits and erroring out

Describe the solution you'd like

Implement / adapt the same approach as @korowa did in #8020 (❤️ ) to incrementally create join output for joins that match many keys rather than doing it all at once.

Describe alternatives you've considered

No response

Additional context

No response

@alamb alamb added the enhancement New feature or request label Jan 22, 2024
@alamb alamb changed the title NestedLoopsJoin memory tracking insufficient NestedLoopsJoin memory tracking may be insufficient Jan 22, 2024
@yyy1000
Copy link
Contributor

yyy1000 commented Jan 30, 2024

I'd like a try to help it. :)

@alamb
Copy link
Contributor Author

alamb commented Jan 30, 2024

THis one may be tricky, FWIW. The join code is not simple.

@yyy1000
Copy link
Contributor

yyy1000 commented Jan 30, 2024

Aha, seems true. Maybe I can leave it here now and find some not so difficult. And I think I could fix it when I get more familiar with the code.❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants