Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"cargo msrv verify" in CI #8961

Closed
mustafasrepo opened this issue Jan 23, 2024 · 5 comments
Closed

"cargo msrv verify" in CI #8961

mustafasrepo opened this issue Jan 23, 2024 · 5 comments
Labels
bug Something isn't working

Comments

@mustafasrepo
Copy link
Contributor

Describe the bug

I am not sure here is the correct place to ask this. I am asking here in case someone experienced or someone who encountered similar problem can help me.

While working in a PR, CI fails during cargo msrv verify with error

Using check command cargo check
   Failed check command cargo check didn't succeed
Crate source was found to be incompatible with its MSRV '1.70.0', as defined in '/__w/arrow-datafusion/arrow-datafusion/datafusion/core/Cargo.toml'

However, it doesn't really say what is the problem. In the PR I didn't change any Cargo.toml file. I am not sure, how I triggerred it. Is there anyone with suggestions?

To Reproduce

No response

Expected behavior

No response

Additional context

No response

@mustafasrepo mustafasrepo added the bug Something isn't working label Jan 23, 2024
@haohuaijin
Copy link
Contributor

It seems like you use the rust feature that rust version > 1.70.0.
cargo msrv verify check datafusion should work for 1.70.0

@mustafasrepo
Copy link
Contributor Author

Thanks @haohuaijin It seems that ahash=0.8.7 has features from rust=1.75.0. It seems to be the problem.

@alamb
Copy link
Contributor

alamb commented Jan 24, 2024

What PR caused the problem?

@mustafasrepo
Copy link
Contributor Author

What PR caused the problem?

It was this PR in synnada repo. However, upgrading dependencies fixed it. It no longer has this problem. I asked here, in case someone could help me understand better the root cause.
Closing this issue now it is not relevant with datafusion per se. @haohuaijin for the suggestion again

@alamb
Copy link
Contributor

alamb commented Jan 25, 2024

What PR caused the problem?

It was this PR in synnada repo. However, upgrading dependencies fixed it. It no longer has this problem. I asked here, in case someone could help me understand better the root cause. Closing this issue now it is not relevant with datafusion per se. @haohuaijin for the suggestion again

I filed #8995 to add some comments to try and help anyone else who may encounter this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants