Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Cargo.lock to the repo root #968

Closed
houqp opened this issue Sep 4, 2021 · 0 comments · Fixed by #982
Closed

Add Cargo.lock to the repo root #968

houqp opened this issue Sep 4, 2021 · 0 comments · Fixed by #982
Labels
enhancement New feature or request

Comments

@houqp
Copy link
Member

houqp commented Sep 4, 2021

Is your feature request related to a problem or challenge? Please describe what you are trying to do.

Builds are not reproducible for datafusion python binding and ballista. Most recently, we got hit by #961.

A Cargo.lock will be useful for projects like datafusion python binding and ballista since they both produce binaries. Right now, our source releases are not reproducible for these two subprojects because we don't ship a lock file to pin dependencies to exact versions. This means if users use our official source release to build binaries, their output could be different than the ones we tested when prepping for the release.

Describe the solution you'd like

Check in Cargo.lock file into the repo.

Additional context

See official guide lines at https://doc.rust-lang.org/cargo/guide/cargo-toml-vs-cargo-lock.html.

@houqp houqp added the enhancement New feature or request label Sep 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant