Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move ceil, exp, factorial to datafusion-functions crate #9939

Closed
erenavsarogullari opened this issue Apr 4, 2024 · 4 comments · Fixed by #10083
Closed

Move ceil, exp, factorial to datafusion-functions crate #9939

erenavsarogullari opened this issue Apr 4, 2024 · 4 comments · Fixed by #10083
Assignees
Labels
enhancement New feature or request

Comments

@erenavsarogullari
Copy link
Member

erenavsarogullari commented Apr 4, 2024

Is your feature request related to a problem or challenge?

As part of #9285 move the ceil, exp, factorial functions to the new datafusion-functions crate in the new structure. Follow-up to #9862.

Describe the solution you'd like

Functions are migrated to the new crate and use the new patterns as described in #9286 & #9216

Describe alternatives you've considered

No response

Additional context

No response

@erenavsarogullari
Copy link
Member Author

take

@alamb
Copy link
Contributor

alamb commented Apr 13, 2024

Any update on this ticket @erenavsarogullari ?

@erenavsarogullari
Copy link
Member Author

@alamb Thanks for follow-up, will be submitting PR shortly.

@alamb
Copy link
Contributor

alamb commented Apr 15, 2024

@alamb Thanks for follow-up, will be submitting PR shortly.

Awesome -- thank you @erenavsarogullari 🙏 (I was following up here as I saw @Omega359 's comment #9540 (comment) which got me inspired to help push the functon porting project over the finish line with some cheerleading)

Thanks again

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants