Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DSIP-19][Feature] Add connection center feature for DS #10283

Open
3 tasks done
Tracked by #14102
EricGao888 opened this issue May 29, 2022 · 18 comments
Open
3 tasks done
Tracked by #14102

[DSIP-19][Feature] Add connection center feature for DS #10283

EricGao888 opened this issue May 29, 2022 · 18 comments
Assignees
Labels
backend discussion discussion feature new feature good idea Stale UI ui and front end related

Comments

@EricGao888
Copy link
Member

EricGao888 commented May 29, 2022

Search before asking

  • I had searched in the issues and found no similar feature requirement.

Description

  • Add Connection Center feature for Dolphin Scheduler so that plugins will be able to achieve connection information such as host, endpoint, credentials to external system and switch them easily without restarting DS.

Use case

image

Related issues

No response

Are you willing to submit a PR?

  • Yes I am willing to submit a PR!

Code of Conduct

@EricGao888 EricGao888 added feature new feature Waiting for reply Waiting for reply labels May 29, 2022
@github-actions
Copy link

Thank you for your feedback, we have received your issue, Please wait patiently for a reply.

  • In order for us to understand your request as soon as possible, please provide detailed information、version or pictures.
  • If you haven't received a reply for a long time, you can join our slack and send your question to channel #troubleshooting

@EricGao888
Copy link
Member Author

Could anyone please help add the discussion label to this issue? I think we need some discussions for the design of this feature : )

@Amy0104 Amy0104 added UI ui and front end related backend and removed Waiting for reply Waiting for reply labels May 30, 2022
@songjianet songjianet added this to the 3.1.0-alpha milestone May 30, 2022
@davidzollo
Copy link
Contributor

good idea

@EricGao888
Copy link
Member Author

This feature would be something like extended datasource feature which we already have. The difference is that all task plugins besides SQL related ones could gain access to it.

@EricGao888
Copy link
Member Author

BTW, as discussed, we need some kind of data masking mechanism to hide sensitive data. Should we open another issue for data masking?

@EricGao888
Copy link
Member Author

EricGao888 commented Jun 18, 2022

BTW, as discussed, we need some kind of data masking mechanism to hide sensitive data. Should we open another issue for data masking?

Added here: #10498

@SbloodyS
Copy link
Member

It seems that this is more like a configuration center in ds. WDYT? @EricGao888

@EricGao888
Copy link
Member Author

It seems that this is more like a configuration center in ds. WDYT? @EricGao888

@SbloodyS Exactly.

@EricGao888 EricGao888 changed the title [Feature] Add connection center feature for DS [Feature] Add configuration center feature for DS Jun 21, 2022
@EricGao888
Copy link
Member Author

EricGao888 commented Jun 21, 2022

Seems there would be two kinds of configurations if we implement this feature on the basis of current data center.

  1. Connection related configurations for datasource, task plugins, etc.
  2. Some common configurations which are in common.properties at present.

BTW, we may still keep less-frequently-changed and high-risky configurations in common.properties.

@EricGao888
Copy link
Member Author

Could you please help add a discussion label for this issue? Thx @SbloodyS

@SbloodyS
Copy link
Member

Could you please help add a discussion label for this issue? Thx @SbloodyS

Sure.

@SbloodyS SbloodyS added the discussion discussion label Jun 21, 2022
@SbloodyS SbloodyS removed this from the 3.1.0-alpha milestone Jun 21, 2022
@SbloodyS
Copy link
Member

Seems there would be two kinds of configurations if we implement this feature on the basis of current data center.

  1. Connection related configurations for datasource, task plugins, etc.
  2. Some common configurations which are in common.properties at present.

BTW, we may still keep less-frequently-changed and high-risky configurations in common.properties.

Yes. I think the data source center should be part of the configuration center.

@EricGao888
Copy link
Member Author

Some ideas about user experience:

  • We will have each task plugin bound with default connection, which corresponds to task types.
  • We set default values in default connections so that new users to Dolphin Scheduler will not need to spend time figuring out what this configuration center does if they just try some basic stuff.
  • Users will be able to see default example values in connection related configurations to help them understand how to manage connections.

@EricGao888
Copy link
Member Author

Rules for configuration update should be established at the very beginning to avoid confusion.

@EricGao888
Copy link
Member Author

I will give a design later this month. For the first stage, we will focus on task plugin connections part.

@EricGao888 EricGao888 changed the title [Feature] Add configuration center feature for DS [Feature] Add connection center feature for DS Apr 4, 2023
@zhongjiajie zhongjiajie changed the title [Feature] Add connection center feature for DS [DSIP][Feature] Add connection center feature for DS May 17, 2023
@zhongjiajie zhongjiajie changed the title [DSIP][Feature] Add connection center feature for DS [DSIP-19][Feature] Add connection center feature for DS May 17, 2023
@qingwli
Copy link
Member

qingwli commented May 17, 2023

Hi @EricGao888 , Could you help realize multiple resource centers?

@EricGao888
Copy link
Member Author

Hi @EricGao888 , Could you help realize multiple resource centers?

We have already removed singleton design for storage operators in backend. Therefore, it is possible to support multiple remote resource storages in resource center. But we need a good design for UI interactions.

Copy link

github-actions bot commented Nov 9, 2024

This issue has been automatically marked as stale because it has not had recent activity for 30 days. It will be closed in next 7 days if no further activity occurs.

@github-actions github-actions bot added the Stale label Nov 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend discussion discussion feature new feature good idea Stale UI ui and front end related
Projects
Status: In Progress
Development

No branches or pull requests

7 participants