Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Improvement][Style] Change spotless ratchetFrom #11412

Closed
3 tasks done
EricGao888 opened this issue Aug 11, 2022 · 1 comment · Fixed by #12412
Closed
3 tasks done

[Improvement][Style] Change spotless ratchetFrom #11412

EricGao888 opened this issue Aug 11, 2022 · 1 comment · Fixed by #12412
Assignees
@caishunfeng @EricGao888
Labels
backend improvement make more easy to user or prompt friendly
Milestone
3.2.0

Comments

@EricGao888
Copy link
Member

Search before asking

  • I had searched in the issues and found no similar feature requirement.

Description

  • We use fork-pull model during open-source contributions, which means we have upstream/main in local and origin/main in remote. Therefore, I set ratchetFrom as HEAD.
  • However, it is a better practice to set ratchetFrom to a specific branch instead of HEAD. After I consulted an expert of spotless project, there is a good way to do so as suggested here: ratchetFrom 'origin/main' does not fetch if not present diffplug/spotless#710 (comment)

Are you willing to submit a PR?

  • Yes I am willing to submit a PR!

Code of Conduct
@EricGao888 EricGao888 added improvement make more easy to user or prompt friendly backend labels Aug 11, 2022
@EricGao888 EricGao888 self-assigned this Aug 11, 2022
@EricGao888 EricGao888 changed the title [Improvement][Style] Change spotless ratcheFrom [Improvement][Style] Change spotless ratchetFrom Aug 11, 2022
@github-actions
Copy link

Thank you for your feedback, we have received your issue, Please wait patiently for a reply.

  • In order for us to understand your request as soon as possible, please provide detailed information、version or pictures.
  • If you haven't received a reply for a long time, you can join our slack and send your question to channel #troubleshooting

@EricGao888 EricGao888 added this to the 3.1.0 milestone Aug 11, 2022
@caishunfeng caishunfeng self-assigned this Sep 8, 2022
@EricGao888 EricGao888 mentioned this issue Sep 20, 2022
Merged
@EricGao888 EricGao888 modified the milestones: 3.1.0, 3.2.0 Sep 20, 2022
This was referenced Oct 17, 2022
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@caishunfeng caishunfeng

@EricGao888 EricGao888

Labels
backend improvement make more easy to user or prompt friendly
Projects
None yet
Milestone
3.2.0
Development

Successfully merging a pull request may close this issue.

[Improvement][Style] Fix remaining style errors and wildcard imports EricGao888/dolphinscheduler
2 participants
@caishunfeng @EricGao888