Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug][dolphinScheduler-task-seatunnel] Script suffixes can be .conf or .json #15706

Closed
2 of 3 tasks
xi-xi-jun opened this issue Mar 13, 2024 · 4 comments · Fixed by #15852
Closed
2 of 3 tasks

[Bug][dolphinScheduler-task-seatunnel] Script suffixes can be .conf or .json #15706

xi-xi-jun opened this issue Mar 13, 2024 · 4 comments · Fixed by #15852
Assignees
Labels
bug Something isn't working

Comments

@xi-xi-jun
Copy link

Search before asking

  • I had searched in the issues and found no similar feature requirement.

Description

Dear DolphinScheduler Development Team,

First and foremost, I would like to express my gratitude for the exceptional tool you have provided. The flexibility and efficiency of SeaTunnel in data processing are immensely valuable to our projects.

During my experience with SeaTunnel, I noticed that when users opt for the HOCON format for scriptwriting, the generated script files have a .conf extension. Conversely, when scripts are written in JSON format, the logical expectation is for the file extension to be .json. However, it seems that the current implementation defaults to a .conf extension through hardcoding, which could lead to execution failures when JSON format scripts are used.

To enhance user experience and increase flexibility in script format support, I suggest adding an option button in the UI's task definition section that allows users to flexibly choose the file type extension (either .conf or .json) based on the script format they are using. Such an improvement would not only prevent potential execution errors but also provide a more intuitive recognition of script formats, making the use of SeaTunnel more user-friendly and efficient.

I believe this minor enhancement could significantly improve the usability and accuracy of SeaTunnel. Thank you for considering my suggestion; I look forward to your response.

image

Are you willing to submit a PR?

  • Yes I am willing to submit a PR!

Code of Conduct

@xi-xi-jun xi-xi-jun added improvement make more easy to user or prompt friendly Waiting for reply Waiting for reply labels Mar 13, 2024
@xi-xi-jun
Copy link
Author

If you currently want to use json scripts instead of HOCON scripts, you can change the .conf in the dolphinscheduler-task-seatunnel project to .json and repackage and compile it.
image

@SbloodyS SbloodyS added good first issue good first issue and removed Waiting for reply Waiting for reply labels Mar 14, 2024
@CallMeKingsley97
Copy link
Contributor

Do you want to contribute for this improvement? This is a good first issue

@ruanwenjun ruanwenjun added the help wanted Extra attention is needed label Mar 18, 2024
@xinxingi
Copy link
Contributor

@ruanwenjun please assign to me

@SbloodyS SbloodyS removed help wanted Extra attention is needed good first issue good first issue labels Apr 15, 2024
@caishunfeng caishunfeng added bug Something isn't working and removed improvement make more easy to user or prompt friendly labels Apr 16, 2024
@caishunfeng
Copy link
Contributor

This issue looks more like a bug, so I change the label for it.

@caishunfeng caishunfeng changed the title [Improvement][dolphinScheduler-task-seatunnel] Script suffixes can be .conf or .json [Bug][dolphinScheduler-task-seatunnel] Script suffixes can be .conf or .json Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants