Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DSIP-44] Add owner for provider managed plugins #16093

Open
2 of 3 tasks
Tracked by #14102
EricGao888 opened this issue May 30, 2024 · 7 comments
Open
2 of 3 tasks
Tracked by #14102

[DSIP-44] Add owner for provider managed plugins #16093

EricGao888 opened this issue May 30, 2024 · 7 comments
Assignees

Comments

@EricGao888
Copy link
Member

EricGao888 commented May 30, 2024

Search before asking

  • I had searched in the issues and found no similar feature requirement.

Description

IMHO we could classify current plugins into two categories:

  1. Community-Managed plugins: widely-used plugins such as shell, hive, spark, flink, etc.
  2. Provider-Managed plugins: plugins used in specific scenario, which enriches the open-source ecosystem of Dolphin.

With the growing number of provider-managed plugins, the community do not have enough hands to ensure the stability and security. Therefore, I suggest each provider-managed plugin should have an owner, responsible for the stability and security issues. Before each release of Dolphin, we need the owners to submit a test report for the plugins they cover. Failure to submit test reports within release date for three consecutive times will lead to the retirement of the plugin.

We could call for a vote later to decide which plugins will be managed by the community.

[WIP] Community-Managed Plugins:

  • shell
  • hive
  • spark
  • flink
  • ......

[WIP] Provider-Managed Plugins:

Name Owner
dataquality-plugin
zeppelin-plugin @EricGao888
jupyter-plugin @EricGao888
......

Are you willing to submit a PR?

  • Yes I am willing to submit a PR!

Code of Conduct

@EricGao888 EricGao888 added the discussion discussion label May 30, 2024
@EricGao888 EricGao888 added this to the 3.3.0 milestone May 30, 2024
@SbloodyS
Copy link
Member

I'm big +1 on this.

@ruanwenjun
Copy link
Member

ruanwenjun commented May 30, 2024

+1, I added to DSIP

@ruanwenjun ruanwenjun changed the title [Discussion] Add owner for provider managed plugins [DSIP] Add owner for provider managed plugins May 30, 2024
@ruanwenjun ruanwenjun changed the title [DSIP] Add owner for provider managed plugins [DSIP-44] Add owner for provider managed plugins Jun 13, 2024
@hanhanzhang
Copy link

@EricGao888 Hi, I'm interested in this issue, we also need to support user-defined plugins. Is there any design for this capability?

@EricGao888
Copy link
Member Author

@EricGao888 Hi, I'm interested in this issue, we also need to support user-defined plugins. Is there any design for this capability?

Hi, this proposal is not a design. This is about maintenance. Dolphin has supported many kinds of plugins since years before. You could check the dolphinscheduler-task-plugin folders if you want to add a customized one.

@hanhanzhang
Copy link

@EricGao888 Hi, I'm interested in this issue, we also need to support user-defined plugins. Is there any design for this capability?

Hi, this proposal is not a design. This is about maintenance. Dolphin has supported many kinds of plugins since years before. You could check the dolphinscheduler-task-plugin folders if you want to add a customized one.

Thanks for your reply. Business wants to package task plugin into products, eg: for HTTP tasks, business wants to package HTTP services into product plugins, which can be directly used in multiple scenarios. At present, Dolphin's sub-workflow should also be able to meet the requirements. We are considering whether Dolphin community plans to compare this capability with the UDF in SQL and allow users to customize task plugins.

@SbloodyS
Copy link
Member

Hi @hanhanzhang , you can raise a new issue to discuss it first.

@hanhanzhang
Copy link

hanhanzhang commented Aug 27, 2024

Hi @hanhanzhang , you can raise a new issue to discuss it first.

Thanks for reply@SbloodyS , I have created a new issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants