Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DSIP-54][Master] Use ClusterManager to manage the cluster in master #16262

Closed
2 tasks done
ruanwenjun opened this issue Jul 2, 2024 · 0 comments · Fixed by #16263
Closed
2 tasks done

[DSIP-54][Master] Use ClusterManager to manage the cluster in master #16262

ruanwenjun opened this issue Jul 2, 2024 · 0 comments · Fixed by #16263
Assignees
Labels

Comments

@ruanwenjun
Copy link
Member

Search before asking

  • I had searched in the DSIP and found no similar DSIP.

Motivation

Right now, ds will use master slot to calculate the command slot, and use worker group mapping to select the worker to dispatched the task to worker.

The problem is the code in master is difficult to maintain, there are rise a lot of bug related to the node manager. This PR is aim to refactor the ServerNodeManager and split the code in different component.

Design Detail

The design looks like below:
image

ClusterManager: used to manage the metadata of the whole clusters include master clusters/worker clusters.
MasterClusters: used to manage the metadata of the master clusters.
WorkerCluster: used to manage the metadata of the worker clusters, include the worker group mapping.

The key point is split the business code from registry, the business code don't need to take care of the registry component.

Compatibility, Deprecation, and Migration Plan

Compatibility

Test Plan

Test by UT and E2E

Code of Conduct

@ruanwenjun ruanwenjun added Waiting for reply Waiting for reply DSIP labels Jul 2, 2024
@ruanwenjun ruanwenjun self-assigned this Jul 2, 2024
@SbloodyS SbloodyS removed the Waiting for reply Waiting for reply label Jul 3, 2024
@SbloodyS SbloodyS changed the title [DSIP-49][Master] Use ClusterManager to manage the cluster in master [DSIP-54][Master] Use ClusterManager to manage the cluster in master Jul 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants