Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improvement][Deployment] DS should support providing direct deployment solutions on public cloud-managed Kubernetes platform #16434

Closed
3 tasks done
SEZ9 opened this issue Aug 10, 2024 · 6 comments
Labels

Comments

@SEZ9
Copy link

SEZ9 commented Aug 10, 2024

Search before asking

  • I had searched in the issues and found no similar feature requirement.

Description

I strongly support the idea of DS enabling direct deployment on cloud-managed Kubernetes services, particularly Amazon EKS. Here are the reasons:

Growing Cloud Adoption: In today's rapidly evolving cloud computing landscape, over 45% of enterprises in China have adopted public cloud technologies as of 2023, with an annual growth rate of 5%. Managed Kubernetes services are a crucial part of this trend. According to Amazon Web Services, 82% of Kubernetes applications in the cloud run on AWS EKS. As a stable platform, DS should be compatible with such deployment solutions.

Open Source and Compatibility: Open source software is widely embraced because of its neutrality and compatibility, allowing for broad adoption. It should not be limited to supporting only certain open-source services while neglecting cloud-native managed services.

Enhanced Flexibility and Cloud-Native Features: While DS currently offers a Terraform Amazon EC2 deployment solution, this approach lacks the elasticity and full utilization of cloud-native features that an EKS deployment offers. For instance, serverless databases provide better elasticity for DS, and tools like Karpenter enable faster, more efficient scaling.

In conclusion, DS should support deployment across multiple platforms, including public cloud deployment solutions.

Are you willing to submit a PR?

  • Yes I am willing to submit a PR!

Code of Conduct

@SEZ9 SEZ9 added improvement make more easy to user or prompt friendly Waiting for reply Waiting for reply labels Aug 10, 2024
@SEZ9 SEZ9 changed the title [Improvement][Module Name] DS should support providing direct deployment solutions on public cloud-managed Kubernetes platform [Improvement][Deployment] DS should support providing direct deployment solutions on public cloud-managed Kubernetes platform Aug 10, 2024
@SbloodyS SbloodyS added discussion discussion feature new feature kubernetes and removed Waiting for reply Waiting for reply improvement make more easy to user or prompt friendly labels Aug 10, 2024
@SbloodyS
Copy link
Member

SbloodyS commented Aug 10, 2024

DS is an open source component, like Flink and Doris. We only want to support open source k8s. Each public cloud has its own > customized implementation of k8s, and we don't provide deployment solutions for all of them.
These should be implemented by the public cloud itself.

I have already express my my opinion in #16433. I'm -1 on this. Let's see others opinion. @ruanwenjun @Gallardot @EricGao888 @caishunfeng

@Gallardot
Copy link
Member

I reviewed this PR #16433 . What specific EKS capabilities is this PR trying to add? karpenter ?

The PR also copies an existing set of Helm charts. Are there any deficiencies with deploying directly using current Helm charts? Why is this new functionality needed? Why not enhance the existing capabilities?

I'm -1 on this.

@SEZ9
Copy link
Author

SEZ9 commented Aug 10, 2024

This PR enhances the DS deployment in dolphinscheduler/deploy/terraform/aws. Originally, the deployment was on AWS EC2, but now it supports AWS EKS, with automatic integration of Amazon Aurora Serverless v2 for the database, EFS for persistent storage, S3 for remote logs, and automatic IAM role construction. It also reuses some open-source Kubernetes Helm charts. #16433

@SEZ9
Copy link
Author

SEZ9 commented Aug 10, 2024

Here's a simple summary of the key enhancements in this PR:

  1. Provides users with a one-click Terraform solution for automatically deploying infrastructure and the DolphinScheduler system on AWS.
  2. Integrates key cloud-native features to enhance the robustness of DolphinScheduler's cloud architecture, including managed EKS clusters, Karpenter for elastic scaling, Amazon Aurora Serverless v2 for automatic database scaling, EFS for persistent shared network storage, Amazon S3 for remote logs, dependency and attachment management, and AWS IAM authentication management.
  3. Maintains compatibility with the existing DolphinScheduler/deploy/terraform/aws container features.
  4. Commits to ongoing maintenance of the modules as DolphinScheduler and AWS services are upgraded.
  5. Enhances the convenience and robustness of using DolphinScheduler on the cloud.

@qingwli
Copy link
Member

qingwli commented Aug 12, 2024

I was -1 on this. My idea is like @SbloodyS

If we want to run ds in eks, we should do some effects on aws part, like they can use some modules or images, like one-click start an eks with ds.

Not change some helm in ds part.

@SEZ9 SEZ9 closed this as completed Aug 12, 2024
@EricGao888
Copy link
Member

IMHO - #16433 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants