Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] [dolphinscheduler-master] AsyncMasterTask may causing a ramp-up in thread pool invocations #16460

Closed
3 tasks done
Dyqer opened this issue Aug 14, 2024 · 1 comment · Fixed by #16461
Closed
3 tasks done
Labels
bug Something isn't working

Comments

@Dyqer
Copy link
Contributor

Dyqer commented Aug 14, 2024

Search before asking

  • I had searched in the issues and found no similar issues.

What happened

Here are some mistakes about AsyncMasterTask

  1. AsyncTask execute times won't be increased
  2. The timeout unit is incorrect, the timeout was supposed to be in minutes, but in the code, it was set to seconds.
  3. If a dependent task is set with a timeout, its execution frequency will increase as it gets closer to the timeout, it will cause DB down if you have lots tasks.

What you expected to happen

  1. we should schedule master async task with a fixed delay instead of fixed rate to avoid service crashes caused by resource exhaustion

How to reproduce

  1. create some denpendent Task with timeout (like 1 minutes)
  2. watch the execute times for async task execution context.

Anything else

No response

Version

3.2.x

Are you willing to submit PR?

  • Yes I am willing to submit a PR!

Code of Conduct

@SbloodyS
Copy link
Member

cc @ruanwenjun

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
2 participants