Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improvement][Master] For logical tasks on the Master, there should be support for dry run #16612

Closed
3 tasks done
shouwangyw opened this issue Sep 13, 2024 · 6 comments · Fixed by #16616
Closed
3 tasks done
Assignees
Labels
backend improvement make more easy to user or prompt friendly priority:high
Milestone

Comments

@shouwangyw
Copy link
Contributor

shouwangyw commented Sep 13, 2024

Search before asking

  • I had searched in the issues and found no similar feature requirement.

Description

When I run the workflow and select 'Dry Run', other non-logic tasks will succeed directly, but the logic tasks will not succeed immediately
image

Are you willing to submit a PR?

  • Yes I am willing to submit a PR!

Code of Conduct

@shouwangyw shouwangyw added improvement make more easy to user or prompt friendly Waiting for reply Waiting for reply labels Sep 13, 2024
@SbloodyS
Copy link
Member

Please describe your issue in more detail

@SbloodyS SbloodyS removed the Waiting for reply Waiting for reply label Sep 13, 2024
@shouwangyw
Copy link
Contributor Author

shouwangyw commented Sep 13, 2024

Please describe your issue in more detail
When I run the workflow and select 'Dry Run', other non-logic tasks will succeed directly, but the logic tasks will run normally and will not succeed immediately

@SbloodyS
Copy link
Member

Which version you are using?

@shouwangyw
Copy link
Contributor Author

shouwangyw commented Sep 13, 2024

Which version you are using?

I am using version 3.1.3, but I see that the latest version does not support dry running for logic tasks either

In the latest version, dry runs are only effective for non-logical tasks submitted to the Worker
image

@SbloodyS
Copy link
Member

After checking it out, I found that this feature was missing in version 3, it was there in version 2. We will add it back in dev. Thanks for pointing out. @shouwangyw

@shouwangyw
Copy link
Contributor Author

shouwangyw commented Sep 13, 2024

After checking it out, I found that this feature was missing in version 3, it was there in version 2. We will add it back in dev. Thanks for pointing out. @shouwangyw

I attempted to solve this issue by submitting pr, please check it.

Recently, our project needs to support debugging DAGs in development mode, where logic tasks are skipped by default. Considering using a dry run is more suitable, hence we discovered this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend improvement make more easy to user or prompt friendly priority:high
Projects
None yet
2 participants