Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enhancement] (nereids)implement DropUserCommand in nereids #44431

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

[Enhancement] (nereids)implement DropUserCommand in nereids #44431

wants to merge 2 commits into from
+136 −1

Conversation

Vallishp
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #42615

Related PR: #xxx

Problem Summary:
implement DropUserCommand in nereids

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@Vallishp
Copy link
Contributor Author

run buildall

@Vallishp
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 39752 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit fa8ecb039fdd6838ae74edceea2a9c6d87e1d898, data reload: false

------ Round 1 ----------------------------------
q1	17585	7513	7233	7233
q2	2061	181	167	167
q3	10695	1085	1168	1085
q4	10559	721	670	670
q5	7617	2722	2736	2722
q6	239	153	150	150
q7	997	632	599	599
q8	9223	1815	1959	1815
q9	6491	6355	6345	6345
q10	6984	2335	2308	2308
q11	469	271	260	260
q12	410	215	211	211
q13	17772	3059	2994	2994
q14	247	215	215	215
q15	601	529	515	515
q16	684	580	601	580
q17	978	547	594	547
q18	7346	6955	6630	6630
q19	1335	1063	950	950
q20	469	188	190	188
q21	4123	3254	3279	3254
q22	382	316	314	314
Total cold run time: 107267 ms
Total hot run time: 39752 ms

----- Round 2, with runtime_filter_mode=off -----
q1	7244	7220	7257	7220
q2	327	229	228	228
q3	2879	2750	2924	2750
q4	2069	1841	1850	1841
q5	5622	5652	5655	5652
q6	230	147	148	147
q7	2310	1813	1832	1813
q8	3402	3562	3475	3475
q9	8900	8900	8875	8875
q10	3625	3532	3559	3532
q11	609	532	510	510
q12	861	628	614	614
q13	12001	3309	3279	3279
q14	308	272	267	267
q15	571	526	544	526
q16	696	681	629	629
q17	1889	1659	1614	1614
q18	8265	7946	7525	7525
q19	1686	1634	1517	1517
q20	2108	1892	1866	1866
q21	5682	5813	5443	5443
q22	643	558	597	558
Total cold run time: 71927 ms
Total hot run time: 59881 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 197100 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit fa8ecb039fdd6838ae74edceea2a9c6d87e1d898, data reload: false

query1	1240	923	947	923
query2	6254	2119	2089	2089
query3	10786	3858	4060	3858
query4	68141	28991	23667	23667
query5	4911	466	444	444
query6	411	190	190	190
query7	5477	307	294	294
query8	319	226	234	226
query9	8520	2662	2665	2662
query10	434	253	249	249
query11	17201	15311	15931	15311
query12	159	105	104	104
query13	1492	450	433	433
query14	10738	7596	7438	7438
query15	208	188	196	188
query16	7352	472	475	472
query17	1162	575	557	557
query18	1873	299	302	299
query19	207	163	149	149
query20	115	134	112	112
query21	208	114	102	102
query22	4785	4528	4680	4528
query23	35006	34624	34053	34053
query24	5392	2527	2509	2509
query25	520	383	393	383
query26	678	144	146	144
query27	2056	284	289	284
query28	4536	2490	2485	2485
query29	673	440	418	418
query30	219	159	154	154
query31	1048	814	839	814
query32	67	51	55	51
query33	427	290	293	290
query34	934	541	532	532
query35	854	744	742	742
query36	1099	971	977	971
query37	127	79	74	74
query38	4459	4435	4427	4427
query39	1539	1453	1550	1453
query40	217	102	105	102
query41	45	41	46	41
query42	110	100	101	100
query43	548	532	485	485
query44	1194	854	850	850
query45	185	169	163	163
query46	1148	722	704	704
query47	2061	1936	1979	1936
query48	415	326	326	326
query49	730	402	420	402
query50	842	401	408	401
query51	7432	7120	7118	7118
query52	97	83	86	83
query53	250	177	180	177
query54	508	399	384	384
query55	83	72	84	72
query56	255	245	237	237
query57	1319	1168	1160	1160
query58	225	215	224	215
query59	3192	3045	2958	2958
query60	275	242	266	242
query61	114	113	110	110
query62	792	679	661	661
query63	207	187	194	187
query64	1468	668	649	649
query65	3286	3251	3199	3199
query66	651	299	304	299
query67	16042	15577	15728	15577
query68	3959	584	583	583
query69	428	247	253	247
query70	1210	1155	1115	1115
query71	333	250	243	243
query72	6372	4066	4041	4041
query73	766	365	362	362
query74	10359	9037	8927	8927
query75	3420	2715	2651	2651
query76	1759	1124	1049	1049
query77	505	282	293	282
query78	10469	9471	9419	9419
query79	1632	598	596	596
query80	1382	428	439	428
query81	518	323	238	238
query82	1298	119	120	119
query83	268	148	166	148
query84	282	77	76	76
query85	1004	305	302	302
query86	424	301	305	301
query87	4690	4675	4649	4649
query88	3627	2270	2224	2224
query89	420	294	309	294
query90	1857	186	186	186
query91	137	105	105	105
query92	62	49	48	48
query93	2032	551	542	542
query94	754	308	292	292
query95	338	244	253	244
query96	630	277	275	275
query97	2886	2714	2732	2714
query98	209	191	196	191
query99	1640	1328	1292	1292
Total cold run time: 320988 ms
Total hot run time: 197100 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 32.93 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit fa8ecb039fdd6838ae74edceea2a9c6d87e1d898, data reload: false

query1	0.03	0.03	0.03
query2	0.07	0.04	0.03
query3	0.23	0.07	0.07
query4	1.63	0.10	0.11
query5	0.42	0.40	0.42
query6	1.16	0.66	0.65
query7	0.02	0.01	0.01
query8	0.04	0.02	0.03
query9	0.57	0.51	0.51
query10	0.56	0.56	0.56
query11	0.13	0.10	0.10
query12	0.14	0.11	0.11
query13	0.61	0.60	0.60
query14	2.83	2.73	2.70
query15	0.90	0.85	0.82
query16	0.38	0.35	0.38
query17	1.08	1.08	1.07
query18	0.22	0.20	0.20
query19	1.88	1.87	1.99
query20	0.01	0.00	0.01
query21	15.36	0.60	0.58
query22	2.68	2.09	2.11
query23	16.98	0.97	0.85
query24	3.28	1.37	0.95
query25	0.25	0.23	0.19
query26	0.44	0.14	0.14
query27	0.04	0.05	0.04
query28	10.30	1.10	1.08
query29	12.51	3.28	3.28
query30	0.25	0.07	0.07
query31	2.83	0.37	0.37
query32	3.31	0.48	0.47
query33	3.03	3.00	3.06
query34	17.14	4.46	4.38
query35	4.53	4.46	4.45
query36	0.67	0.49	0.48
query37	0.09	0.06	0.06
query38	0.04	0.03	0.04
query39	0.03	0.03	0.02
query40	0.16	0.13	0.13
query41	0.08	0.02	0.02
query42	0.04	0.02	0.02
query43	0.04	0.03	0.03
Total cold run time: 106.99 s
Total hot run time: 32.93 s

@Vallishp
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 40206 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit b58cfdb44f5a282b62d8ce5b51a0f465a3a23638, data reload: false

------ Round 1 ----------------------------------
q1	17599	7481	7321	7321
q2	2041	176	166	166
q3	10772	1130	1207	1130
q4	10542	738	701	701
q5	7596	2751	2688	2688
q6	245	151	149	149
q7	969	628	607	607
q8	9253	1878	1964	1878
q9	6644	6429	6404	6404
q10	7037	2326	2323	2323
q11	473	263	267	263
q12	420	222	220	220
q13	17777	3065	3113	3065
q14	258	213	218	213
q15	589	529	517	517
q16	666	595	592	592
q17	966	531	508	508
q18	7301	6761	6650	6650
q19	1363	1040	1021	1021
q20	470	185	182	182
q21	4070	3301	3373	3301
q22	383	318	307	307
Total cold run time: 107434 ms
Total hot run time: 40206 ms

----- Round 2, with runtime_filter_mode=off -----
q1	7355	7337	7279	7279
q2	325	228	225	225
q3	2884	2849	2973	2849
q4	2109	1868	1904	1868
q5	5711	5671	5704	5671
q6	236	148	145	145
q7	2294	1819	1827	1819
q8	3424	3554	3563	3554
q9	8902	8981	8912	8912
q10	3619	3579	3611	3579
q11	600	524	533	524
q12	825	576	596	576
q13	10775	3258	3225	3225
q14	318	273	269	269
q15	572	520	525	520
q16	693	667	661	661
q17	1850	1663	1605	1605
q18	8362	7868	7675	7675
q19	1710	1555	1571	1555
q20	2165	1902	1892	1892
q21	5605	5443	5402	5402
q22	631	579	592	579
Total cold run time: 70965 ms
Total hot run time: 60384 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 198363 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit b58cfdb44f5a282b62d8ce5b51a0f465a3a23638, data reload: false

query1	1242	966	966	966
query2	6242	2127	2056	2056
query3	10946	3929	4164	3929
query4	68344	27237	23660	23660
query5	4966	473	473	473
query6	412	192	190	190
query7	5579	314	303	303
query8	322	237	223	223
query9	8824	2699	2677	2677
query10	438	270	260	260
query11	17342	15358	15945	15358
query12	168	108	100	100
query13	1503	426	399	399
query14	10616	7650	7364	7364
query15	207	213	183	183
query16	7135	508	487	487
query17	1110	565	575	565
query18	1961	309	294	294
query19	217	165	153	153
query20	122	113	112	112
query21	213	105	118	105
query22	4840	4654	4536	4536
query23	34888	34487	34368	34368
query24	5519	2571	2591	2571
query25	508	391	410	391
query26	647	157	153	153
query27	1906	286	286	286
query28	4554	2494	2481	2481
query29	713	428	430	428
query30	218	155	155	155
query31	994	806	852	806
query32	69	60	63	60
query33	458	302	316	302
query34	998	519	532	519
query35	874	743	752	743
query36	1120	990	985	985
query37	137	79	75	75
query38	4525	4360	4457	4360
query39	1573	1486	1495	1486
query40	222	108	111	108
query41	53	50	47	47
query42	111	106	110	106
query43	558	503	512	503
query44	1227	847	847	847
query45	190	200	183	183
query46	1236	757	721	721
query47	2054	1897	1928	1897
query48	430	323	332	323
query49	733	408	406	406
query50	910	401	415	401
query51	7535	7251	7151	7151
query52	99	85	88	85
query53	270	186	182	182
query54	517	413	407	407
query55	76	81	75	75
query56	247	247	254	247
query57	1318	1194	1178	1178
query58	225	212	222	212
query59	3265	3070	3151	3070
query60	269	248	248	248
query61	113	105	106	105
query62	817	704	679	679
query63	216	194	197	194
query64	1356	701	652	652
query65	3370	3205	3246	3205
query66	707	297	316	297
query67	16168	15891	15595	15595
query68	3954	583	565	565
query69	443	262	272	262
query70	1219	1137	1160	1137
query71	370	269	255	255
query72	6464	4214	4175	4175
query73	807	379	368	368
query74	10132	9196	8989	8989
query75	3519	2711	2660	2660
query76	1716	1191	1210	1191
query77	525	286	295	286
query78	10575	9505	9506	9505
query79	1443	602	592	592
query80	881	465	440	440
query81	513	238	227	227
query82	1321	118	121	118
query83	272	164	151	151
query84	279	74	69	69
query85	888	306	339	306
query86	337	296	302	296
query87	4770	4727	4641	4641
query88	3735	2295	2220	2220
query89	424	297	300	297
query90	1987	192	189	189
query91	138	105	103	103
query92	70	53	52	52
query93	1792	556	553	553
query94	778	293	305	293
query95	342	257	250	250
query96	678	293	284	284
query97	2864	2773	2705	2705
query98	223	209	192	192
query99	1819	1306	1314	1306
Total cold run time: 322020 ms
Total hot run time: 198363 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 32.4 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit b58cfdb44f5a282b62d8ce5b51a0f465a3a23638, data reload: false

query1	0.03	0.03	0.03
query2	0.06	0.04	0.03
query3	0.24	0.08	0.07
query4	1.64	0.10	0.10
query5	0.42	0.43	0.42
query6	1.17	0.66	0.66
query7	0.02	0.01	0.02
query8	0.04	0.03	0.03
query9	0.60	0.51	0.50
query10	0.55	0.55	0.55
query11	0.14	0.10	0.10
query12	0.15	0.12	0.12
query13	0.62	0.62	0.61
query14	2.71	2.82	2.82
query15	0.90	0.82	0.83
query16	0.39	0.39	0.39
query17	1.08	1.05	1.02
query18	0.21	0.20	0.20
query19	1.90	1.89	2.07
query20	0.01	0.01	0.01
query21	15.36	0.61	0.58
query22	2.89	2.43	1.92
query23	17.09	0.84	0.90
query24	3.31	0.45	0.95
query25	0.13	0.07	0.07
query26	0.55	0.14	0.14
query27	0.04	0.05	0.04
query28	11.06	1.10	1.07
query29	12.50	3.26	3.24
query30	0.24	0.07	0.06
query31	2.87	0.40	0.39
query32	3.25	0.46	0.47
query33	3.06	2.97	3.18
query34	16.84	4.48	4.54
query35	4.56	4.52	4.54
query36	0.65	0.52	0.48
query37	0.10	0.07	0.06
query38	0.05	0.04	0.04
query39	0.03	0.03	0.03
query40	0.16	0.12	0.11
query41	0.08	0.02	0.02
query42	0.03	0.02	0.02
query43	0.03	0.03	0.03
Total cold run time: 107.76 s
Total hot run time: 32.4 s

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Nov 22, 2024
@github-actions GitHub Actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions GitHub Actions
Copy link
Contributor

PR approved by anyone and no changes requested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@starocean999 starocean999 starocean999 approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by one committer. reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Enhancement] (nereids)implement DropUserCommand in nereids
3 participants
@Vallishp @doris-robot @starocean999