[BUG] Fix field error in information_schema.columns #4858
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -186,6 +186,8 @@ std::string SchemaColumnsScanner::type_to_string(TColumnDesc &desc) { | |
| } | ||
| } | ||
|
|
||
| //fill row in the "INFORMATION_SCHEMA COLUMNS" | ||
| //Reference from https://dev.mysql.com/doc/refman/8.0/en/information-schema-columns-table.html | ||
| Status SchemaColumnsScanner::fill_one_row(Tuple *tuple, MemPool *pool) { | ||
| // set all bit to not null | ||
| memset((void *)tuple, 0, _tuple_desc->num_null_bytes()); | ||
|
|
@@ -236,9 +238,22 @@ Status SchemaColumnsScanner::fill_one_row(Tuple *tuple, MemPool *pool) { | |
| { | ||
| void *slot = tuple->get_slot(_tuple_desc->slots()[6]->tuple_offset()); | ||
| StringValue* str_slot = reinterpret_cast<StringValue*>(slot); | ||
|
|
||
| if (_desc_result.columns[_column_index].columnDesc.__isset.isAllowNull) { | ||
| if (_desc_result.columns[_column_index].columnDesc.isAllowNull) { | ||
| str_slot->len = strlen("YES"); | ||
| str_slot->ptr = (char *)pool->allocate(str_slot->len); | ||
| memcpy(str_slot->ptr, "YES", str_slot->len); | ||
| } else { | ||
| str_slot->len = strlen("NO"); | ||
| str_slot->ptr = (char *)pool->allocate(str_slot->len); | ||
| memcpy(str_slot->ptr, "NO", str_slot->len); | ||
| } | ||
| } else { | ||
| str_slot->len = strlen("NO"); | ||
| str_slot->ptr = (char *) pool->allocate(str_slot->len); | ||
| memcpy(str_slot->ptr, "NO", str_slot->len); | ||
| } | ||
| } | ||
| // DATA_TYPE | ||
| { | ||
|
|
@@ -250,20 +265,33 @@ Status SchemaColumnsScanner::fill_one_row(Tuple *tuple, MemPool *pool) { | |
| memcpy(str_slot->ptr, buffer.c_str(), str_slot->len); | ||
| } | ||
| // CHARACTER_MAXIMUM_LENGTH | ||
| // For string columns, the maximum length in characters. | ||
| { | ||
| int data_type = _desc_result.columns[_column_index].columnDesc.columnType; | ||
| if (data_type == TPrimitiveType::VARCHAR || data_type == TPrimitiveType::CHAR) { | ||
| void *slot = tuple->get_slot(_tuple_desc->slots()[8]->tuple_offset()); | ||
| int64_t* str_slot = reinterpret_cast<int64_t*>(slot); | ||
| if (_desc_result.columns[_column_index].columnDesc.__isset.columnLength) { | ||
| *str_slot = _desc_result.columns[_column_index].columnDesc.columnLength; | ||
| } else { | ||
| tuple->set_null(_tuple_desc->slots()[8]->null_indicator_offset()); | ||
| } | ||
| } else { | ||
| tuple->set_null(_tuple_desc->slots()[8]->null_indicator_offset()); | ||
| } | ||
| } | ||
| // CHARACTER_OCTET_LENGTH | ||
| // For string columns, the maximum length in bytes. | ||
| { | ||
| int data_type = _desc_result.columns[_column_index].columnDesc.columnType; | ||
| if (data_type == TPrimitiveType::VARCHAR || data_type == TPrimitiveType::CHAR) { | ||
| void *slot = tuple->get_slot(_tuple_desc->slots()[9]->tuple_offset()); | ||
| int64_t* str_slot = reinterpret_cast<int64_t*>(slot); | ||
| if (_desc_result.columns[_column_index].columnDesc.__isset.columnLength) { | ||
| *str_slot = _desc_result.columns[_column_index].columnDesc.columnLength * 4; | ||
|
Contributor
Author
There was a problem hiding this comment. For mysql-compatible purposes, we need to multiply this by 4. |
||
| } else { | ||
| tuple->set_null(_tuple_desc->slots()[9]->null_indicator_offset()); | ||
| } | ||
| } else { | ||
| tuple->set_null(_tuple_desc->slots()[9]->null_indicator_offset()); | ||
| } | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No need to plus 1?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think +1 is necessary here, and +1 will cause the character matching of the SQL result to fail. Such as IS_NULLABLE = "YES" is false