Skip to content

branch-3.1: [fix](cloud) Sync storage resource once in read path when rowset._storage_resource.fs is null #53075 #53228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
morrySnow merged 1 commit into from
Jul 15, 2025
Merged

branch-3.1: [fix](cloud) Sync storage resource once in read path when rowset._storage_resource.fs is null #53075 #53228

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 12 additions & 4 deletions be/src/olap/rowset/rowset_meta.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@
#include <memory>
#include <random>

#include "cloud/cloud_storage_engine.h"
#include "common/logging.h"
#include "google/protobuf/util/message_differencer.h"
#include "io/fs/file_writer.h"
Expand Down Expand Up @@ -112,16 +113,23 @@ Result<const StorageResource*> RowsetMeta::remote_storage_resource() {
}

if (!_storage_resource.fs) {
// not initialized yet
auto storage_resource = get_storage_resource(resource_id());
if (storage_resource) {
if (auto storage_resource = get_storage_resource(resource_id())) {
_storage_resource = std::move(storage_resource->first);
} else {
if (config::is_cloud_mode()) {
// When creating a new cluster or creating a storage resource, BE may not sync storage resource,
// at the moment a query is coming, the BetaRowsetReader call loadSegment and use this method
// to get the storage resource, so we need to sync storage resource here.
ExecEnv::GetInstance()->storage_engine().to_cloud().sync_storage_vault();
if (auto retry_resource = get_storage_resource(resource_id())) {
_storage_resource = std::move(retry_resource->first);
return &_storage_resource;
}
}
return ResultError(Status::InternalError("cannot find storage resource. resource_id={}",
resource_id()));
}
}

return &_storage_resource;
}

Expand Down
Loading