Skip to content

[Fix](funtion) Fix utc_time result when input null #57716

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zclllyybb merged 2 commits into from
Nov 5, 2025
Merged

[Fix](funtion) Fix utc_time result when input null #57716

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7c1bb4d
[Fix](funtion) Fix utc_time result when input null
linrrzqqq Nov 5, 2025
0ce8fb8
fix err_msg
linrrzqqq Nov 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions ...re/src/main/java/org/apache/doris/nereids/trees/expressions/functions/scalar/UtcTime.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,8 +84,13 @@ public FunctionSignature computeSignature(FunctionSignature signature) {

@Override
public void checkLegalityAfterRewrite() {
if (arity() == 1 && !child(0).isLiteral()) {
throw new AnalysisException("UTC_TIME scale argument must be a constant literal.");
if (arity() == 1) {
if (child(0).isNullLiteral()) {
throw new AnalysisException("UTC_TIME argument cannot be NULL.");
}
if (!child(0).isLiteral()) {
throw new AnalysisException("UTC_TIME scale argument must be a constant literal.");
}
}
}

Expand Down
9 changes: 7 additions & 2 deletions ...c/main/java/org/apache/doris/nereids/trees/expressions/functions/scalar/UtcTimestamp.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,8 +79,13 @@ public FunctionSignature computeSignature(FunctionSignature signature) {

@Override
public void checkLegalityAfterRewrite() {
if (arity() == 1 && !child(0).isLiteral()) {
throw new AnalysisException("UTC_TIMESTAMP scale argument must be a constant literal.");
if (arity() == 1) {
if (child(0).isNullLiteral()) {
throw new AnalysisException("UTC_TIMESTAMP argument cannot be NULL.");
}
if (!child(0).isLiteral()) {
throw new AnalysisException("UTC_TIMESTAMP scale argument must be a constant literal.");
}
}
}

Expand Down
9 changes: 9 additions & 0 deletions regression-test/suites/query_p0/sql_functions/datetime_functions/test_date_function.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -506,7 +506,12 @@ suite("test_date_function") {
sql """ select utc_timestamp(7) """
exception "scale must be between 0 and 6"
}
test {
sql """ SELECT UTC_TIMESTAMP(NULL); """
exception "UTC_TIMESTAMP argument cannot be NULL."
}

// UTC_TIME
def utc_time_str = sql """ select utc_time(),utc_time() + 1 """
assertTrue(utc_time_str[0].size() == 2)
utc_time_str = sql """ select utc_time(6), utc_time(6) + 1 """
Expand All @@ -515,6 +520,10 @@ suite("test_date_function") {
sql """ select utc_time(7) """
exception "scale must be between 0 and 6"
}
test {
sql """ SELECT UTC_TIME(NULL); """
exception "UTC_TIME argument cannot be NULL."
}

def utc_date_str = sql """ select utc_date(),utc_date() + 1 """
assertTrue(utc_date_str[0].size() == 2)
Expand Down
Loading