-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Store bitmap sizes along with bitmaps in the segment format #3882
Comments
One thing to be careful of here is that 4 bytes per bitmap can add up quickly for high cardinality dimensions. Still a useful idea though. |
@gianm we can use condensed integer encodings, where the highest bit of each byte is a continuation flag. Numbers 0-127 take just 1 byte. |
yes, for sure that is a valid approach. Just wanting to make sure that this issue is considered. It may also be worth while to skip the size field for small bitmaps where computing size is fast. Odds are, high cardinality dimensions will generally have small bitmaps. I'm not sure though since I'm not sure of the speed difference between reading a vsize int and computing size for a small bitmap. |
This issue has been marked as stale due to 280 days of inactivity. |
This issue has been closed due to lack of activity. If you think that |
Absence of precomputed bitmap sizes makes implementation of features like #3878 and #3848 much less effective than it could be.
The text was updated successfully, but these errors were encountered: