Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store bitmap sizes along with bitmaps in the segment format #3882

Closed
leventov opened this issue Jan 25, 2017 · 5 comments
Closed

Store bitmap sizes along with bitmaps in the segment format #3882

leventov opened this issue Jan 25, 2017 · 5 comments

Comments

@leventov
Copy link
Member

leventov commented Jan 25, 2017

Absence of precomputed bitmap sizes makes implementation of features like #3878 and #3848 much less effective than it could be.

@gianm
Copy link
Contributor

gianm commented Jan 25, 2017

One thing to be careful of here is that 4 bytes per bitmap can add up quickly for high cardinality dimensions. Still a useful idea though.

@leventov
Copy link
Member Author

leventov commented Jan 25, 2017

@gianm we can use condensed integer encodings, where the highest bit of each byte is a continuation flag. Numbers 0-127 take just 1 byte.

@gianm
Copy link
Contributor

gianm commented Jan 26, 2017

yes, for sure that is a valid approach. Just wanting to make sure that this issue is considered. It may also be worth while to skip the size field for small bitmaps where computing size is fast. Odds are, high cardinality dimensions will generally have small bitmaps. I'm not sure though since I'm not sure of the speed difference between reading a vsize int and computing size for a small bitmap.

@github-actions
Copy link

This issue has been marked as stale due to 280 days of inactivity.
It will be closed in 4 weeks if no further activity occurs. If this issue is still
relevant, please simply write any comment. Even if closed, you can still revive the
issue at any time or discuss it on the dev@druid.apache.org list.
Thank you for your contributions.

@github-actions github-actions bot added the stale label May 31, 2023
@github-actions
Copy link

This issue has been closed due to lack of activity. If you think that
is incorrect, or the issue requires additional review, you can revive the issue at
any time.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Jun 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants