Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dubbo-go注册service不支持自定义registry-group? #1139

Closed
trust-freedom opened this issue Apr 9, 2021 · 4 comments
Closed

dubbo-go注册service不支持自定义registry-group? #1139

trust-freedom opened this issue Apr 9, 2021 · 4 comments
Labels
good first issue Good for newcomers

Comments

@trust-freedom
Copy link

What would you like to be added:
看 servicediscovery/base_registry.go providerRegistry() 中对registry-group是写死的,如下

dubboPath = fmt.Sprintf("/dubbo/%s/%s", r.service(c), common.DubboNodes[common.PROVIDER])

请问是不支持自定义registry-group吗??

Why is this needed:
支持自定义registry-group,感觉这是比较常用的特性

@zhaoyunxing92
Copy link
Contributor

一般修改这个需求很少吧,这个可以认为是一个默认的配置

@trust-freedom
Copy link
Author

这个registry group我们主要用于环境隔离,否则都在/dubbo下,同公司包名类似,可能会出现ServiceName相同的情况,感觉应该也有不少是这么使用的吧?请问这块之后会支持吗?配置和dubbo java版本靠拢

@AlexStocks
Copy link
Contributor

u can try to submit a pr to implement this feature. thx.

@zhaoyunxing92
Copy link
Contributor

可以看下这个 https://github.com/apache/dubbo-go-samples/tree/master/group 支持分组的

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants