Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

protoc-gen-go-dubbo 改进建议 #1461

Closed
XiaoWeiKIN opened this issue Sep 16, 2021 · 2 comments
Closed

protoc-gen-go-dubbo 改进建议 #1461

XiaoWeiKIN opened this issue Sep 16, 2021 · 2 comments
Labels
help wanted Extra attention is needed

Comments

@XiaoWeiKIN
Copy link
Contributor

grpc:

// UnimplementedSpecialServer can be embedded to have forward compatible implementations.
type UnimplementedSpecialServer struct {
}

func (*UnimplementedSpecialServer) GetName(context.Context, *SpecialRequest) (*SpecialReply, error) {
	return nil, status.Errorf(codes.Unimplemented, "method GetName not implemented")
}
func (*UnimplementedSpecialServer) SayHello(context.Context, *SpecialRequest) (*SpecialReply, error) {
	return nil, status.Errorf(codes.Unimplemented, "method SayHello not implemented")
}

dubbbo-go:

type SpecialProviderBase struct {
	proxyImpl protocol.Invoker
}

xxxProviderBase 也默认的实现下接口的方法,不然业务代码需要把接口放方法全部实现

@LaurenceLiZhixin
Copy link
Contributor

Refactor of protoc-gen-go-dubbo3grpc needs help, which is needed to be fixed at :https://github.com/dubbogo/tools/tree/master/cmd/protoc-gen-dubbo3grpc

@LaurenceLiZhixin
Copy link
Contributor

LaurenceLiZhixin commented Nov 25, 2021

refer to: #1460 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants