Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance: Optimize remotes configuration and constructor #501

Closed
flycash opened this issue May 2, 2020 · 2 comments · Fixed by #687
Closed

Enhance: Optimize remotes configuration and constructor #501

flycash opened this issue May 2, 2020 · 2 comments · Fixed by #687
Assignees
Labels
enhancement New feature or request occupied Issue has been occupied
Milestone

Comments

@flycash
Copy link
Member

flycash commented May 2, 2020

What would you like to be added:

Remotes Configuration.

Why is this needed:

Now, there are many implementations based on different middleware, including zookeeper, nacos...
However, we do not have a common way to configure those middleware.
For example, If I want to use the Nacos as registry and configure center, I must configure the Nacos in two different places:

Nacos as configure center

Nacos as registry

It's not convenient for users. If the user wants to change the address, he must change all places.

So I propose that we should define the RemoteConfig, it looks like:

remotes:
  nacos1:
     address: "1.1.1.1:8080"

registries:
  nacos1:
    protocol: "nacos",
    remoteRef: "nacos1",

config_center:
  protocol: "nacos"
  remoteRef: "nacos1",
@flycash flycash added this to the 1.5.1 milestone May 2, 2020
@AlexStocks
Copy link
Contributor

sounds good.

@zouyx zouyx added the enhancement New feature or request label Jun 29, 2020
@zouyx zouyx self-assigned this Jul 2, 2020
@zouyx zouyx added the occupied Issue has been occupied label Jul 2, 2020
@zouyx zouyx linked a pull request Aug 2, 2020 that will close this issue
@zouyx
Copy link
Member

zouyx commented Aug 9, 2020

finished

@zouyx zouyx closed this as completed Aug 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request occupied Issue has been occupied
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants