Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Monitor stats not accurate #1592

Closed
jpzhang1230 opened this issue Apr 12, 2018 · 3 comments
Closed

Monitor stats not accurate #1592

jpzhang1230 opened this issue Apr 12, 2018 · 3 comments

Comments

@jpzhang1230
Copy link

发现一个问题,在启用simple-monitor时,发现第一次调用rpc时,触发MonitorFilter的collect方法时,
Monitor monitor = monitorFactory.getMonitor(url);
if (monitor == null) {
return;
}
此时的monitor为空。后续接着调用rpc时,monitor又不为空。所以怀疑是MonitorFactory延迟加载导致。这里会导致一个问题,就是Collect的数量总是比实际少几条。

@beiwei30 beiwei30 changed the title Monitor采集数据不准 Monitor stats not accurate Apr 12, 2018
@beiwei30
Copy link
Member

it's relevant to #777

@chickenlj
Copy link
Contributor

We think monitoring data don't need to be accurate, though we will try to record every RPC statistics, it should not block the RPC process.

@chickenlj
Copy link
Contributor

Feel free to reopen this issue if necessary.

Next time, please use english, also, you can subscribe to dev@dubbo.apache.org to discuss questions like this, just send your questions to this mail address, and we will guarantee a better and quicker reply there.

How to subscribe, see #1393.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants