New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize least active load balance. #2540

Closed

carryxyh opened this issue Sep 20, 2018 · 1 comment

Assignees

Member

carryxyh commented Sep 20, 2018

There are two places in LeasActiveLoadBalance that need to be optimized.

When calculating the total weight, we use a weight that has not been processed by warmup. When multiple invokers have the same active request and weight, we use the weight of the warmup, which is not uniform.
When multiple invokers have the same active request and weight, we randomly select them by weight. There is a bug here that causes the actual randomness to not be strictly weighted.

The pr to fix this two problem:
#2172

The related issue:
#904

carryxyh mentioned this issue

LeastActiveLoadBalance负载均衡 #904

Closed

carryxyh self-assigned this

carryxyh added the type/enhancement label

Member Author

carryxyh commented Sep 28, 2018

closed via #2172 (comment)

carryxyh closed this as completed

carryxyh mentioned this issue

Optimize LeastActiveLoadBalance and add weight test case. #2584

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment