Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE] some nessary information is not In ServiceMetadata #4370

Closed
2 tasks done
vio-lin opened this issue Jun 21, 2019 · 0 comments
Closed
2 tasks done

[ISSUE] some nessary information is not In ServiceMetadata #4370

vio-lin opened this issue Jun 21, 2019 · 0 comments

Comments

@vio-lin
Copy link
Contributor

vio-lin commented Jun 21, 2019

  • I have searched the issues of this repository and believe that this is not a duplicate.
  • I have checked the FAQ of this repository and believe that this is not a duplicate.

Environment

  • Dubbo version: 2.7.3
  • Operating System version: win7
  • Java version: jdk8

Steps to reproduce this issue

  1. define a service Interface like this.
public interface HelloBOMService {
  PersonResponseType get(PersonRequestType request) throws Exception;
}
  1. getServiceDefinition and print Method Parameter
 ServiceDefinition serviceDefinition = ServiceDefinitionBuilder.build(HelloBOMService.class);
        System.out.println(serviceDefinition.getMethods().get(0).getParameters());
  1. the methodDefition return an empty list

  2. Extends TypeBuilder to construct Protobuf typeBuilder and add SPI file.

@SPI
public interface TypeBuilder {
  1. Use serviceDefition.getTypes() to obtains all TypeDefinitions. It is nessary to know which TypeDefinitionBuilder build this TypeDefition.When TypeBuilder generate same ServiceDefinition
    use different logic.

Expected Result

We could get parameter type list from MethodDefition.
We should know which Builder build this TypeDefition.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant