Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete unused code, defaultPort can not be null. #4479

Closed
TingSky opened this issue Jul 5, 2019 · 2 comments
Closed

Delete unused code, defaultPort can not be null. #4479

TingSky opened this issue Jul 5, 2019 · 2 comments

Comments

@TingSky
Copy link
Contributor

TingSky commented Jul 5, 2019

Delete unused code.
DefaultPort can not be null.
The code can never reached.
image
@TingSky
Copy link
Contributor Author

TingSky commented Jul 5, 2019

submit PR, TBR
#4480

@CrazyHZM
Copy link
Member

CrazyHZM commented Jul 5, 2019

It has been merged, thank you.

@CrazyHZM CrazyHZM closed this as completed Jul 5, 2019
@dubbo-bot dubbo-bot mentioned this issue Jul 12, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@TingSky @CrazyHZM