-
Notifications
You must be signed in to change notification settings - Fork 19.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix(brush): clamp range when brush #14569
Conversation
Thanks for your contribution! The pull request is marked to be |
Congratulations! Your PR has been merged. Thanks for your contribution! 👍 |
Found some exists very old bad designs during the review. Going to fix it in a separate PR For example: |
Brief Information
This pull request is in the type of:
What does this PR do?
It should clamp range when brush, otherwise, range would larger than 1, because brushed area might exceed the last item.
Fixed issues
Close #14416
Details
Before: What was the problem?
After: How is it fixed in this PR?
Usage
Are there any API changes?
Related test cases or examples to use the new APIs
brush3.html
Others
Merging options
Other information