-
Notifications
You must be signed in to change notification settings - Fork 19.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(sankey): support trajectory
for emphasis state
#17451
Conversation
Thanks for your contribution! Document changes are required in this PR. Please also make a PR to apache/echarts-doc for document changes and update the issue id in the PR description. When the doc PR is merged, the maintainers will remove the |
|
Hey I know you're busy, when this will get review ? @plainheart @pissang |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this feature is cool! Thanks for your contribution. I'm just checking a few basic problems here.
Is there any release date for this PR merge ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for late reply. Our next version is to be released in Feb 2023.
…of focus method name in test
…ase to sankey.html
@plainheart Fixed code by your recommendations |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Let's see if @Ovilia has other comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @Ovilia , This is not a bug, |
@Ovilia I agree with @ElayGelbart. It's a bit hard to see but they do connect with a very thin line. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see! Thanks for your contribution.
Congratulations! Your PR has been merged. Thanks for your contribution! 👍 |
发现个问题:focus 配置为 'trajectory' 时,当节点数 data,超过 100 ,边 links 超过 300 的时候,会导致页面崩溃 |
@lhd163 Thanks for your feedback. Please file a bug report with a reproduction example. |
Graph Emphasis Full Path:
This pull request is in the type of:
this pull request adding the functionality to emphasis the full path from start to finish on hover/highlight event
Fixed issues
Details
Before: What was the problem?
There was only three options, 'self','series','adjacency'. it was needed to emphasis the whole path of nodes/edges to highlight all the related paths to specific node/edge
'adjacency' provide only one before one after emphasis.
After: How does it behave after the fixing?
after we can have
trajectory
option on emphasis:focusDocument Info
One of the following should be checked.
trajectory
for emphasis focus of sankey echarts-doc#276Misc
ZRender Changes
Related test cases or examples to use the new APIs
Please refer to
test/emphasis-fullPath.html
Others
Merging options
Other information