fix(animation): fix incorrect dataGroupId
for old data items in universalTransition
#17559
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief Information
This pull request is in the type of:
What does this PR do?
dataGroupId for old data items in universalTransition is mistakenly set to that of new data items, not the expected old one. So fix it.
Fixed issues
Details
Before: What was the problem?
echarts/src/animation/universalTransition.ts
Line 210 in 89d57f2
When processing old data items, after executing this line, dataGroupId is wrongly assigned a value that is belong to new data items. That will cause universalTransition not work if we fall back to depend on dataGroupId to decide dataItem's key.
After: How does it behave after the fixing?
By storing the old dataGroupId in globalStore, now the correct old dataGroupId can be accessed!
Document Info
One of the following should be checked.
childGroupId
echarts-doc#295I think the example should be updated with
dataGroupId
inseries
field.Misc
ZRender Changes
Related test cases or examples to use the new APIs
N.A.
Others
Merging options
Other information
Thanks for @pissang's instruction!