-
Notifications
You must be signed in to change notification settings - Fork 19.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(candlestick): provide borderColorDoji option for custom doji color #17717
Conversation
Thanks for your contribution! The pull request is marked to be |
Document changes are required in this PR. Please also make a PR to apache/echarts-doc for document changes and update the issue id in the PR description. When the doc PR is merged, the maintainers will remove the |
Looks great! I'm not famaliar with the term |
@pissang Doji means the shape is like a cross (十) so there should be no filling color. So I believe |
Thanks for the explaination |
Congratulations! Your PR has been merged. Thanks for your contribution! 👍 |
feat(candlestick): add doc for borderColorDoji apache/echarts#17717
Brief Information
This pull request is in the type of:
What does this PR do?
Provide option
series-candlestick.itemStyle.borderColorDoji
to set custom doji color.Fixed issues
#11042
Details
Before: What was the problem?
Doji means the open and close value of a data item is the same. Previously, it can either be
borderColor
orborderColor0
according to the previous data item. But if developers want to change it to a custom color, like a neutral colour like gary, it cannot be done.After: How does it behave after the fixing?
So in this PR, we provide a new option
borderColorDoji
. If it is set, this color is used for all doji data items.Document Info
One of the following should be checked.
Misc
ZRender Changes
Related test cases or examples to use the new APIs
test/candlestick-doji.html
Others
Merging options
Other information