Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(type): add missing function callback into lineStyle.color for lines series. #17780

Merged
merged 1 commit into from
Nov 13, 2022
Merged

fix(type): add missing function callback into lineStyle.color for lines series. #17780

merged 1 commit into from
Nov 13, 2022

Conversation

plainheart
Copy link
Member

@plainheart plainheart commented Oct 17, 2022 •
edited
Loading

Brief Information

This pull request is in the type of:

  • bug fixing
  • new feature
  • others

What does this PR do?

  • Add missing function callback into lineStyle.color for lines series.
  • Remove unsupported function callback from lineStyle.color in states

Fixed issues

Document Info

One of the following should be checked.

  • This PR doesn't relate to document changes
  • The document should be updated later
  • The document changes have been made in apache/echarts-doc#xxx

Misc

ZRender Changes

  • This PR depends on ZRender changes (ecomfe/zrender#xxx).

Related test cases or examples to use the new APIs

N.A.

Others

Merging options

  • Please squash the commits into a single one when merging.

Other information

@plainheart
fix(lines): add missing function callback into lineStyle.color fo…
e780ba5 
…r line series.

- remove unsupported function callback from `lineStyle.color` in states
@echarts-bot
Copy link

echarts-bot bot commented Oct 17, 2022

Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout the coding standard and Wiki about How to make a pull request.

The pull request is marked to be PR: author is committer because you are a committer of this project.

@plainheart plainheart changed the title fix(lines): add missing function callback into lineStyle.color for line series. fix(lines): add missing function callback into lineStyle.color for lines series. Oct 17, 2022
@plainheart plainheart added this to the 5.4.1 milestone Oct 17, 2022
@plainheart plainheart merged commit 523ddc0 into master Nov 13, 2022
@echarts-bot
Copy link

echarts-bot bot commented Nov 13, 2022

Congratulations! Your PR has been merged. Thanks for your contribution! 👍

@plainheart plainheart deleted the fix/lines-type branch November 13, 2022 04:43
@plainheart plainheart changed the title fix(lines): add missing function callback into lineStyle.color for lines series. fix(type): add missing function callback into lineStyle.color for lines series. Nov 30, 2022
@X-oss-byte X-oss-byte mentioned this pull request May 25, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pissang pissang pissang approved these changes

Assignees
No one assigned
Labels
PR: author is committer PR: doc unchanged size/S
Projects
None yet
Milestone
5.4.1
Development

Successfully merging this pull request may close these issues.

lineStyle attribute in series could not set with function
2 participants
@plainheart @pissang