-
Notifications
You must be signed in to change notification settings - Fork 19.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(markArea): markArea range in bar series #18130 #18229
Conversation
Thanks for your contribution! The pull request is marked to be |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As additional information,
#18150 and #18159 have reported another related bug that was caused by a NPE at markerHelper.ts#L108.
When using markLine
in the pie series, the coordinateSystem
will be undefined, which causes the dims
to be undefined.
And the access to the dims
variable at markerHelper.ts#L155 should also be guarded.
@plainheart Thanks. I've updated the logic and put that in the test. Please check if anything is missing. |
Congratulations! Your PR has been merged. Thanks for your contribution! 👍 |
Brief Information
This pull request is in the type of:
What does this PR do?
Fix the markArea range problem in bar series.
Fixed issues
#18130 and #18099
Details
Before: What was the problem?
The markArea range is wrong in bar series when the axisTick is not all displayed. This was a bug introduced in #17098.
After: How does it behave after the fixing?
tickValue
is the index in the total axis range, rather than the visible part. After the fixing, it works well when axis has interval or with dataZoom.Document Info
One of the following should be checked.
Misc
ZRender Changes
Related test cases or examples to use the new APIs
bar-markArea.html
Others
Merging options
Other information