Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sunburst): fix sunburst label may rotate when labelLayout.hideOverlap is enabled #18808

Merged
merged 1 commit into from
Jun 27, 2023

Conversation

linghaoSu
Copy link
Member

@linghaoSu linghaoSu commented Jun 26, 2023

Brief Information

This pull request is in the type of:

  • bug fixing
  • new feature
  • others

What does this PR do?

Normalize rotation, before and after, will get same value in a specified range.

Fixed issues

Details

Before: What was the problem?

When setting labelLayout: { hideOverlap: true } and hover in/out, the label may be rotation 360 deg, caused by deconstruct from a matrix, direction is the same, but not equal value, so the label's rotation is different from other state's rotation

After: How does it behave after the fixing?

Normalize rotation, before and after, will get same value in a specified range.

Document Info

One of the following should be checked.

  • This PR doesn't relate to document changes
  • The document should be updated later
  • The document changes have been made in apache/echarts-doc#xxx

Misc

ZRender Changes

  • This PR depends on ZRender changes (ecomfe/zrender#xxx).

Related test cases or examples to use the new APIs

N.A.

Others

Merging options

  • Please squash the commits into a single one when merging.

Other information

@echarts-bot
Copy link

echarts-bot bot commented Jun 26, 2023

Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout the coding standard and Wiki about How to make a pull request.

Copy link
Contributor

@Ovilia Ovilia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Thanks for fixing this.

@Ovilia Ovilia merged commit 0ddf9f7 into apache:master Jun 27, 2023
@echarts-bot
Copy link

echarts-bot bot commented Jun 27, 2023

Congratulations! Your PR has been merged. Thanks for your contribution! 👍

@Ovilia Ovilia added this to the 5.4.3 milestone Jun 27, 2023
@linghaoSu linghaoSu deleted the fix/sunburst-rotate-label branch June 27, 2023 15:42
@plainheart plainheart changed the title fix(sunburst): normalize label rotation when decompress from matrix fix(sunburst): fix sunburst label may rotate when labelLayout.hideOverlap is enabled Jul 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Sunburst label may rotate dynamically when mouse hovers in/out.
2 participants