Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(type): add missing value type string for barMinWidth and barMaxWidth of the bar series #19424

Merged
merged 1 commit into from
Dec 20, 2023

Conversation

zhaxnb
Copy link
Contributor

@zhaxnb zhaxnb commented Dec 20, 2023

Brief Information

This pull request is in the type of:

  • bug fixing
  • new feature
  • others

What does this PR do?

Fixed the types of barMinWidth and barMaxWidth.

Fixed issues

Details

Before: What was the problem?

image
image

After: How does it behave after the fixing?

image
image

Document Info

One of the following should be checked.

  • This PR doesn't relate to document changes
  • The document should be updated later
  • The document changes have been made in apache/echarts-doc#xxx

Misc

ZRender Changes

  • This PR depends on ZRender changes (ecomfe/zrender#xxx).

Related test cases or examples to use the new APIs

N.A.

Others

Merging options

  • Please squash the commits into a single one when merging.

Other information

Copy link

echarts-bot bot commented Dec 20, 2023

Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout the coding standard and Wiki about How to make a pull request.

@Ovilia Ovilia merged commit 34f81b6 into apache:master Dec 20, 2023
Copy link

echarts-bot bot commented Dec 20, 2023

Congratulations! Your PR has been merged. Thanks for your contribution! 👍

@plainheart plainheart changed the title Fixed the types of barMinWidth and barMaxWidth fix(type): add missing value type string for barMinWidth and barMaxWidth of the bar series Dec 23, 2023
@plainheart plainheart added this to the 5.5.0 milestone Dec 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants