-
Notifications
You must be signed in to change notification settings - Fork 19.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf(line): reduce runtime memory cost #20161
Conversation
… instance rather than create an new function to reduce runtime memory cost (fix #20151)
Thanks for your contribution! The pull request is marked to be |
The changes brought by this PR can be previewed at: https://echarts.apache.org/examples/editor?version=PR-20161@86db174 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
对比确实相比较之前几乎不再增长
PS: resize 之后也会释放原本占用的空间这个和这个有什么关联么(视频拖动分割线时,右侧代表内存占用的蓝色突然消失)
default.mov
Congratulations! Your PR has been merged. Thanks for your contribution! 👍 |
Brief Information
This pull request is in the type of:
What does this PR do?
Prebind the context of the
_changePolyState
function to the current instance ofLineView
rather than create a new function to reduce runtime memory cost.Fixed issues
Details
Document Info
One of the following should be checked.
Misc
ZRender Changes
Related test cases or examples to use the new APIs
See the online demo
Others
Merging options
Other information