Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Java] Align string array to collection protocol v2 #1227

Closed
chaokunyang opened this issue Dec 10, 2023 · 0 comments · Fixed by #1228
Closed

[Java] Align string array to collection protocol v2 #1227

chaokunyang opened this issue Dec 10, 2023 · 0 comments · Fixed by #1228
Labels
enhancement New feature or request java

Comments

@chaokunyang
Copy link
Collaborator

chaokunyang commented Dec 10, 2023

Is your feature request related to a problem? Please describe.

In #927 , we implement an optimized serialization protocol for Collection, which can reduce space cost and improve performance, this should be applied to array too.

Describe the solution you'd like

  • Create an wrapper List to reuse code in io.fury.serializer.collection.AbstractCollectionSerializer#writeNullabilityHeader for write header
  • Align implementation of string array serialization to collection serializaiton

Additional context

#923 #927

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request java
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant