refactor(java): Streamline ClassResolver responsibilities #1417
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To reduce the complexity of the `ClassResolver` class, we mainly do the following two things: 1. Move ClassId related responsibilities into ClassIdAllocator class. 2. Move `registeredId2ClassInfo` into `ExtRegistry` static inner class since they are content related. Signed-off-by: LiangliangSui <coolsui.coding@gmail.com>
chaokunyang
reviewed
Mar 23, 2024
| private final Fury fury; | ||
| private ClassInfo[] registeredId2ClassInfo = new ClassInfo[] {}; |
There was a problem hiding this comment.
registeredId2ClassInfo is in the critical path, we'd better to keep it here instead of extRegistry, which incur another pointer indirection.
|
Hi @LiangliangSui , thanks for this work. We're standardlizing Fury xlang serialization protocol in #1413 , which may change class resolver too, especially the class id part. Can we hold this until the xlang serialization protocol are merged, so we don't have to refactor The type id is lift to the first-class concept in #1413, we do need to strealine it from class resolver. |
|
Ok, we keep this PR until the xlang serialization protocol is merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To reduce the complexity of the
ClassResolverclass, we mainly do the following two things:Move ClassId related responsibilities into ClassIdAllocator class.
Move
registeredId2ClassInfointoExtRegistrystatic inner class since they are content related.